Re: checkpatch false positon on EXPORT_SYMBOL

[Andy Whitcroft]

On Tue, Apr 12, 2016 at 10:49:17AM -0700, Joe Perches wrote:
> > On Tue, 2016-04-12 at 13:59 +0100, Andy Whitcroft wrote:
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -3000,7 +3000,7 @@ sub process {
> > 
> >  			$realline_next = $line_nr_next;
> >  			if (defined $realline_next &&
> >  			    (!defined $lines[$realline_next - 1] ||
> > -			     substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
> > +			     substr($lines[$realline_next - 1], $off_next) =~ /^($;|\s)*$/)) {
> >  				$realline_next++;
> >   			}
> 
> This doesn't work with c99 comments like:
> 
> int foo;		// comment
> EXPORT_SYMBOL(foo);	// comment
> 
> but then again, there aren't any uses like that in the
> kernel tree so it almost certainly doesn't matter.
> 
> Thanks Andy.

Ok, that makes sense.  Lets try the below.

-apw