Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline

From: Ingo Molnar
Date: Wed Apr 13 2016 - 05:42:11 EST



* Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:

> The local_clock/cpu_clock functions were changed to prevent a double
> identical test with sched_clock_cpu() when HAVE_UNSTABLE_SCHED_CLOCK
> is set. That resulted in one line functions.
>
> As these functions are in all the cases one line functions and in the
> hot path, it is useful to specify them as static inline in order to
> give a strong hint to the compiler.
>
> After verification, it appears the compiler does not inline them
> without this hint. Change those functions to static inline.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---
> include/linux/sched.h | 32 ++++++++++++++++++++++++++++++--
> kernel/sched/clock.c | 41 -----------------------------------------
> 2 files changed, 30 insertions(+), 43 deletions(-)

Hm, this does not seem to apply to v4.6-rc3 cleanly.

Thanks,

Ingo