Re: [PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header

From: Mark Brown
Date: Thu Apr 14 2016 - 02:46:12 EST


On Wed, Apr 13, 2016 at 06:39:13PM +0100, Srinivas Kandagatla wrote:
> This patch adds dummy function for regmap_can_raw_write() in the header
> file, so that the code can be atleast compiled without regmap enabled.
> This kind of setup is mostly tested using randomconfig or zero
> day-testing.

I'm not convinced that this isn't flagging real problems - it's hard to
see how code can safely and sensibly be written which would use this
without a dependency on regmap (and given that and the fact that we have
no external users we should probably make it internal to the API).

Attachment: signature.asc
Description: PGP signature