Re: [PATCH] pinctrl: imx: select regmap subsystem

From: Shawn Guo
Date: Sun Apr 17 2016 - 21:45:17 EST


On Sat, Apr 16, 2016 at 10:26:06PM +0200, Arnd Bergmann wrote:
> Building the imx pinctrl driver without regmap fails with multiple
> build errors like:
>
> drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_probe':
> drivers/pinctrl/freescale/pinctrl-imx.c:723:9: error: variable 'config' has initializer but incomplete type
> struct regmap_config config = { .name = "gpr" };
>
> This adds a 'select REGMAP' statement, to ensure we can define a 'struct
> regmap_config'. This matches what all other regmap users do. The driver
> actually uses syscon on top of regmap, but syscon is already enabled
> on i.MX for other reasons, and selecting REGMAP but not SYSCON is
> sufficient for build testing on other platforms.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")

LinusW already applied a similar patch [1] from Alexander a few days
ago.

Shawn

[1] http://thread.gmane.org/gmane.linux.kernel.gpio/16054