Re: [PATCH] ixgbe: use msleep for long delays

From: David Miller
Date: Mon Apr 18 2016 - 00:04:10 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Sat, 16 Apr 2016 22:35:08 +0200

> The newly added x550em_a support causes a link failure on ARM because of
> an overly long time passed into udelay():
>
> ERROR: "__bad_udelay" [drivers/net/ethernet/intel/ixgbe/ixgbe.ko] undefined!
>
> There are multiple variants of the ixgbe_acquire_swfw_sync_*() function,
> and the other ones all use msleep(), so we can safely assume that all
> callers are allowed to sleep, which makes msleep() a better replacement
> than mdelay().
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: 49425dfc7451 ("ixgbe: Add support for x550em_a 10G MAC type")

I'm assuming Jeff will pick this up.