Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel

[Krzysztof Kozlowski]

On 04/18/2016 11:57 AM, Mark Brown wrote:
> On Mon, Apr 18, 2016 at 09:42:58AM +0200, Krzysztof Kozlowski wrote:
> 
>> On S2MPS11 and S2MPS14 devices the default implementation of
>> set_voltage_time_sel() for LDO regulators was not doing anything useful
>> because users did not provide ramp delay in Device Tree so the
>> set_voltage_time_sel() exited with status 0. This could be seen in
>> dmesg, e.g. on Odroid XU4:
> 
> That's not the bug, the bug is that the driver is providing the
> operation without providing a non-zero value for it.  The device tree
> configuration is to override what the driver is doing.

So your recommendation would be to set the ramp_delay value in
regulator_desc structure?

The problem is that value of 30 mv/us in datasheet looks untrustworthy
(copied from other pages) and vendor kernel (which should be a
reference) uses 12 mv/us. Anyway setting any value greater than 0 seems
like better idea than just sticking to 0...

Best regards,
Krzysztof