Re: [patch -next] udp: fix if statement in SIOCINQ ioctl

From: Willem de Bruijn
Date: Mon Apr 18 2016 - 09:41:50 EST


On Mon, Apr 18, 2016 at 8:19 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> On Mon, 2016-04-18 at 11:44 +0300, Dan Carpenter wrote:
>> We deleted a line of code and accidentally made the "return put_user()"
>> part of the if statement when it's supposed to be unconditional.
>>
>> Fixes: 9f9a45beaa96 ('udp: do not expect udp headers on ioctl SIOCINQ')
>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>

Acked-by: Willem de Bruijn <willemb@xxxxxxxxxx>

Thanks for catching this.