Re: [PATCH v4] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

From: Mark Brown
Date: Mon Apr 18 2016 - 13:22:22 EST

On Mon, Apr 18, 2016 at 08:43:39PM +0800, PC Liao wrote:

> +Optional properties:
> +- sound-dai: audio codec dai on capture path
> + <&rt5650 0> : Default setting. Connect rt5650 I2S1 for capture. (dai_name = rt5645-aif1)
> + <&rt5650 1> : Connect rt5650 I2S2 for capture. (dai_name = rt5645-aif2)

Code-wise this seems fine but it seems like it'd be clearer to call this
capture-dai - this isn't used to select whatr's used for playback, only
for capture.

Attachment: signature.asc
Description: PGP signature