Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity()

From: Jacek Anaszewski
Date: Tue Apr 19 2016 - 03:09:20 EST

Hi Boris,

Thanks for the review, patch applied.

Best regards,
Jacek Anaszewski

On 04/18/2016 04:57 PM, Boris Brezillon wrote:
On Mon, 18 Apr 2016 16:40:46 +0200
Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx> wrote:

Parameters delay_on and delay_off of led_trigger_blink_oneshot()
are pointers, to enable blink interval adjustment by LED class drivers
of the controllers that implement hardware blinking.

Move ide_blink_delay variable to ledtrig_ide_activity() in order to
prevent the situation when adjustment committed by one LED class
driver influences blink interval of the software fallback blink feature,
that is applied to the drivers that don't implement blink_set op.

Signed-off-by: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx>

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>