Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

From: Mika Westerberg
Date: Tue Apr 19 2016 - 09:17:05 EST


On Tue, Apr 19, 2016 at 03:02:06PM +0200, Lars-Peter Clausen wrote:
> On 04/19/2016 02:40 PM, Mika Westerberg wrote:
> > On Mon, Apr 18, 2016 at 05:26:54PM +0200, Lars-Peter Clausen wrote:
> >> A generic API by indexes wont work. The order between DT and ACPI will most
> >> likely be different. I'd even assume that the order will be different with
> >> ACPI for the same device on different platforms.
> >
> > Yes, unfortunately that might be possible.
> >
> >> If we want to support ACPI over the same interface drivers need to provide a
> >> lookup table that maps a name to the index.
> >
> > Indeed something like we already have with GPIOs. The lookup table could
> > be filled from names in _DSD where it is available.
>
> Does that mean you are OK with the patch as it is?

It is still not clear to me if this supports more than two addresses and
if it does, how those are represented in DT and how the function can be
used to fetch all those additional addresses.