Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused
From: Wei Ni
Date: Wed Apr 20 2016 - 02:43:17 EST
On 2016å04æ19æ 20:43, Thierry Reding wrote:
> * PGP Signed by an unknown key
> On Tue, Apr 19, 2016 at 10:35:55AM +0800, Wei Ni wrote:
>> On 2016å04æ18æ 15:15, Thierry Reding wrote:
>>>> Old Signed by an unknown key
>>> On Sat, Apr 16, 2016 at 10:19:33PM +0200, Arnd Bergmann wrote:
>>>> After the PM support has been added to this driver, we get
>>>> a harmless warning when that support is disabled at compile
>>>> drivers/thermal/tegra/soctherm.c:641:12: error: 'soctherm_resume' defined but not used [-Werror=unused-function]
>>>> static int soctherm_resume(struct device *dev)
>>>> This marks the two PM functions as __maybe_unused to shut up
>>>> the warning. This is preferred over adding an #ifdef around
>>>> them, as it is harder to get wrong, and provides better
>>>> compile-time coverage.
>>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>>>> Fixes: a134b4143b65 ("thermal: tegra: add PM support")
>>>> drivers/thermal/tegra/soctherm.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> The need for this should go away when Jon's generic power domain series
>> Hi Thierry,
>> Could you please show me the Jon's generic power domain series, so that I can
>> verify it.
> Here are the remaining patches from Jon's series:
I checked this generic power domain series, it select PM and PM_GENERIC_DOMAINS
for Tegra SoC Family. But the soctherm_suspend/resume callbacks defined by
SIMPLE_DEV_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled, so if the
CONFIG_PM_SLEEP is disabled, we still will get this warning.
So to avoid the warning, I think this patch is needed.
> * Unknown Key
> * 0x7F3EB3A1