Re: [PATCH v2] drivers/idle: make intel_idle.c driver more explicitly non-modular
From: Daniel Lezcano
Date: Wed Apr 20 2016 - 14:13:32 EST
On Wed, Apr 20, 2016 at 11:25:06AM -0400, Paul Gortmaker wrote:
> The Kconfig for this driver is currently declared with:
> config INTEL_IDLE
> bool "Cpuidle Driver for Intel Processors"
> ...meaning that it currently is not being built as a module by anyone.
> This was done in commit 6ce9cd8669fa1195fdc21643370e34523c7ac988
> ("intel_idle: disable module support") since "...the module capability
> is cauing more trouble than it is worth."
> This was done over 5y ago, and Daniel adds that:
> ...the modular support has been removed from almost all the cpuidle
> drivers and the cpuidle framework is no longer assuming driver could
> be unloaded.
> Removing the modular dead code in the driver makes sense as this
> what have been done in the others drivers.
> So lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit. At a
> later date we might want to consider whether subsys_init or another
> init category seems more appropriate than device_init.
> We replace module.h with moduleparam.h since the file does declare
> some module parameters, and leaving them as such is currently the
> easiest way to remain compatible with existing boot arg use cases.
What about using __setup() ? so module* disappear from the file.
> Note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> Also note that we can't remove intel_idle_cpuidle_devices_uninit() as
> that is still used for unwind purposes if the init fails.
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> Cc: Len Brown <len.brown@xxxxxxxxx>
> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Cc: rcochran@xxxxxxxxxxxxx
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>