Re: [PATCH v2] i2c: designware-platdrv: fix unbalanced clk enable and prepare

From: Andy Shevchenko
Date: Thu Apr 21 2016 - 07:02:37 EST

On Thu, 2016-04-21 at 17:26 +0800, Jisheng Zhang wrote:
> If i2c_dw_probe() fail, we should disable and unprepare the clk,

clk -> clock, or use function name explicitly.

> otherwise the clk enable and prepare is left unbalanced.


> In dw_i2c_plat_remove(), we'd better to not rely on rpm to disable
> and unprepare the clk since CONFIG_PM may be disabled when configuring


> the kernel. So we explicitly disable and unprepare the clk in


> dw_i2c_plat_remove().

> + pm_runtime_put_noidle(&pdev->dev);
> Â
> - pm_runtime_put_sync(&pdev->dev);

This change also needs to be described in the commit message.

Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy