Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits

From: Borislav Petkov
Date: Thu Apr 21 2016 - 16:40:11 EST


On Thu, Apr 21, 2016 at 09:17:02PM +0200, Peter Zijlstra wrote:
> So I agree with Thomas; the risk of not doing this is that we'll
> introduce the same MSR again, in another file, under another name.

... only if that MSR is useful in other compilation units. If not, then
you're unlikely to need it somewhere else. That's why I meant if it is
PT-relevant only, to define it in its header instead.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.