Re: [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes

From: Mugunthan V N
Date: Fri Apr 22 2016 - 02:56:09 EST


On Thursday 21 April 2016 11:20 PM, David Rivshin (Allworx) wrote:
> From: David Rivshin <drivshin@xxxxxxxxxxx>
>
> The first patch fixes a bug that makes dual_emac mode break if
> either slave uses the phy-handle property in the devicetree.
>
> The second patch fixes some cosmetic problems with error messages,
> and also makes the binding documentation more explicit.
>
> The third patch cleans up the fixed-link case to work like
> the now-fixed phy-handle case.
>
> I have tested on the following hardware configurations:
> - (EVMSK) dual emac, phy_id property in both slaves
> - (EVMSK) dual emac, phy-handle property in both slaves
> - (BeagleBoneBlack) single emac, phy_id property
> - (custom) single emac, fixed-link subnode
>
> Nicolas Chauvet reported testing on an HP t410 (dm8148).
>
> Markus Brunner reported testing v1 on the following [1]:
> - emac0 with phy_id and emac1 with fixed phy
> - emac0 with phy-handle and emac1 with fixed phy
> - emac0 with fixed phy and emac1 with fixed phy
>
>

Reviewed-by: Mugunthan V N <mugunthanvnm@xxxxxx>

Regards
Mugunthan V N