Re: [PATCH] regulator: arizona-ldo1: Only enable status change if we have LDOENA

From: Mark Brown
Date: Fri Apr 22 2016 - 11:05:04 EST


On Fri, Apr 22, 2016 at 02:43:28PM +0100, Richard Fitzgerald wrote:
> The driver was hardcoding REGULATOR_CHANGE_STATUS on the regulator
> which made the regulator core assume that it can be powered off.
>
> The power state of the regulator is controlled by the LDOENA pin so
> this patch changes to only setting the REGULATOR_CHANGE_STATUS flag
> if we have a valid gpio for LDOENA.

What's the difference between this and the previous version of the patch
and what problem is this aiming to solve? If we want to disable the
regulator why would we not be happy to do that by removing the supply?

Attachment: signature.asc
Description: PGP signature