[PATCH 0/3] Net driver bugs fix and code style

From: Noam Camus
Date: Tue Apr 26 2016 - 03:36:15 EST


From: Elad Kanfi <eladkan@xxxxxxxxxxxx>

Summary:
1. Bug description: TX done interrupts that arrives while interrupts
are masked, during NAPI poll, will not trigger an interrupt handling.
Since TX interrupt is of level edge we will lose the TX done interrupt.
As a result all pending tx frames will get no service.

Solution: Check if there is a pending tx request after unmasking the
interrupt and if answer is yes then re-add ourselves to
the NAPI poll list.

2. Bug description: CPU-A before sending a frame will set a variable
to true. CPU-B that executes the tx done interrupt service routine
might read a non valid value of that variable.

Solution: Add a memory barrier at the tx sending function.

3. In addition, the check of a valid pending tx request was switched
to an inline function to avoid duplicated code.

Elad Kanfi (3):
net: nps_enet: code style
net: nps_enet: Sync access to packet sent flag
net: nps_enet: bug fix - handle lost tx interrupts

drivers/net/ethernet/ezchip/nps_enet.c | 34 +++++++++++++++++++++++++++----
1 files changed, 29 insertions(+), 5 deletions(-)