RE: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

From: Jun Li
Date: Wed Apr 27 2016 - 09:33:28 EST


Hi,

> -----Original Message-----
> From: Jun Li [mailto:jun.li@xxxxxxx]
> Sent: Wednesday, April 27, 2016 8:50 PM
> To: Roger Quadros <rogerq@xxxxxx>; stern@xxxxxxxxxxxxxxxxxxx;
> balbi@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; peter.chen@xxxxxxxxxxxxx
> Cc: dan.j.williams@xxxxxxxxx; jun.li@xxxxxxxxxxxxx;
> mathias.nyman@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; Joao.Pinto@xxxxxxxxxxxx;
> abrestic@xxxxxxxxxxxx; r.baldyga@xxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH v6 08/12] usb: hcd: Adapt to OTG core
>
> Hi
> > -----Original Message-----
> > From: Roger Quadros [mailto:rogerq@xxxxxx]
> > Sent: Wednesday, April 27, 2016 7:12 PM
> > To: Jun Li <jun.li@xxxxxxx>; stern@xxxxxxxxxxxxxxxxxxx;
> > balbi@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; peter.chen@xxxxxxxxxxxxx
> > Cc: dan.j.williams@xxxxxxxxx; jun.li@xxxxxxxxxxxxx;
> > mathias.nyman@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx;
> > Joao.Pinto@xxxxxxxxxxxx; abrestic@xxxxxxxxxxxx; r.baldyga@xxxxxxxxxxx;
> > linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > linux-omap@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core
> >
> > On 27/04/16 14:00, Roger Quadros wrote:
> > > On 27/04/16 13:16, Jun Li wrote:
> > >> Hi
> > >>
> > >>>
> > >>> +
> > >>> +static struct otg_hcd_ops otg_hcd_intf = {
> > >>> + .add = usb_add_hcd,
> > >>> + .remove = usb_remove_hcd,
> > >>> + .usb_bus_start_enum = usb_bus_start_enum,
> > >>
> > >> Build break if CONFIG_USB_OTG is not enabled:
> > >>
> > >> drivers/built-in.o:(.data+0x1db30): undefined reference to
> > `usb_bus_start_enum'
> > >> Makefile:948: recipe for target 'vmlinux' failed
> > >> make: *** [vmlinux] Error 1
> >
> > I couldn't get this error. Could you please send me your .config? Thanks.
>
> imx_v6_v7_defconfig

My bad, no problem now.

Li Jun

>
> >
> > cheers,
> > -roger
> > >
> > > Thanks. Will fix it.
> > >
> > > cheers,
> > > -roger
> > >
> > >>
> > >>> + .usb_control_msg = usb_control_msg,
> > >>> + .usb_hub_find_child = usb_hub_find_child, };
> > >>> +
> > >>
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-usb"
> > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo
> > > info at http://vger.kernel.org/majordomo-info.html
> > >