Re: [PATCH 1/2] bfp tools: Remove expression with no effect

From: Arnaldo Carvalho de Melo
Date: Wed Apr 27 2016 - 10:33:10 EST


Em Wed, Apr 27, 2016 at 11:11:26AM +0800, Wangnan (F) escreveu:
>
>
> On 2016/4/25 10:34, Florian Fainelli wrote:
> >Assigning "attr" to "attr" does not have any effect, but was caught by
> >Coverity, so let's remove this.
> >
> >Reported-by: coverity (CID 1354720)
> >Fixes: 1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature check")
> >Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> >---
> > tools/build/feature/test-bpf.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/tools/build/feature/test-bpf.c b/tools/build/feature/test-bpf.c
> >index b389026839b9..8236df9a46ca 100644
> >--- a/tools/build/feature/test-bpf.c
> >+++ b/tools/build/feature/test-bpf.c
> >@@ -27,7 +27,6 @@ int main(void)
> > attr.log_level = 0;
> > attr.kern_version = 0;
> >- attr = attr;
> > /*
> > * Test existence of __NR_bpf and BPF_PROG_LOAD.
> > * This call should fail if we run the testcase.
>
> Tested-by: Wang Nan <wangnan0@xxxxxxxxxx>

Applied