Re: [PATCH v2] lib: make sg_pool tristate instead of bool

From: Martin K. Petersen
Date: Wed Apr 27 2016 - 19:54:39 EST


>>>>> "Paul" == Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> writes:

Paul> The recently added Kconfig controlling compilation of this code
Paul> is: lib/Kconfig:config SG_POOL lib/Kconfig: def_bool n

Paul> ...meaning that it currently is not being built as a module by
Paul> anyone, and that tripped my audit looking for modular code that is
Paul> essentially orphaned (i.e. module_exit, and .remove fcns in
Paul> non-modular drivers.)

Paul> In the following discussion, Ming Lin indicated that the original
Paul> intention was to have it tristate, so here we convert it
Paul> accordingly.

Paul> Also fix up a couple spelling issues that appear in the
Paul> surrounding patch context.

Somebody please review...

--
Martin K. Petersen Oracle Linux Engineering