Re: [PATCH RESEND 07/12] pci: sh: SH7751 PCI host bridge driver

From: Bjorn Helgaas
Date: Mon May 02 2016 - 15:33:14 EST


On Sun, May 01, 2016 at 02:08:31PM +0900, Yoshinori Sato wrote:

> +static __init int sh7751_pci_probe(struct platform_device *pdev)
> +{
> ...

> + pci->cfg.ops = &pci_sh7751_ops;
> + return pci_host_common_probe(pdev, pci);
> +}
> +
> +static __refdata struct platform_driver sh7751_pci_driver = {
> + .driver = {
> + .name = "sh7751-pci",
> + .of_match_table = sh7751_pci_of_match,
> + },
> + .probe = sh7751_pci_probe,
> +};
> +module_platform_driver(sh7751_pci_driver);

I *think* that if you use builtin_platform_driver_probe() or
module_platform_driver_probe() here, you can get rid of the __refdata
on sh7751_pci_driver while keeping sh7751_pci_probe() as __init.