Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF

From: Kishon Vijay Abraham I
Date: Tue May 03 2016 - 06:59:18 EST




On Sunday 01 May 2016 01:37 AM, Heiko Stübner wrote:
> Hi Kishon,
>
> Am Dienstag, 19. April 2016, 08:13:47 schrieb Heiko Stübner:
>> Hi Kishon.
>>
>> Am Donnerstag, 31. März 2016, 15:43:30 schrieb Heiko Stuebner:
>>> The usb-phy is fully enclosed in the general register files (GRF).
>>> Therefore as seen from the device-tree it shouldn't be a separate
>>> platform-
>>> device but instead a sub-device of the GRF - using the simply-mfd
>>> mechanism.
>>>
>>> As the usb-phy is part of the kernel for some releases now, we keep
>>> the old (and now deprecated) binding for compatibility purposes.
>>>
>>> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
>>
>> could you look into picking this patch up for 4.7?
>>
>> Same principle as for the other phy drivers, but it's already in the kernel
>> for a while, so it gets a fallback for the old binding and can go through
>> the normal way.
>>
>> The other two (devicetree-)patches I would then simply queue for 4.8 myself
>> after you're fine with the driver-side.
>
> just saw that you already have a tag for 4.7-related phy changes since this
> afternoon, but no phy pull to Greg on lkml yet.
>
> So maybe there is still a way for this phy conversion (to be under the
> Rockchip GRF node) to make it in for 4.7 :-) ?

Looks like I've missed this before sending the pull request. Sorry about that.
Is it okay if the PHY changes also go in 4.8?

-Kishon