Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

From: Jeff Moyer
Date: Wed May 04 2016 - 13:59:07 EST


Mike Christie <mchristi@xxxxxxxxxx> writes:

> On 05/03/2016 03:44 PM, Jeff Moyer wrote:
>> Hi, Mike,
>>
>> That git tree doesn't seem to exist. I did manage to apply your patch
>> set on top of next-20160415, though.
>>
>> So... what testing did you do? ;-) I ran into the following problems
>
> I normally run xfstests and run it on my daily workstation and laptop. I
> did not do this for every FS this time and hit a regression.
>
> What FS were you using?

I'm using xfs, scsi disk, no blk-mq, no dm.

>> - git clone fails
>> - yum segfaults
>
> In v7/v6, I missed a new submit_bio call, so I hit issues like the two
> above. I have this fixed in the next version.

OK, does this mean you're posting another version, or you already did
and I somehow missed it?

>> - many blktrace/blkparse issues, including incorrect cpu recorded in
>> traces, null task names, and blkparse outputting nothing for a trace
>> file several gigabytes in size.
>
> I will double check for these issues.

Thanks. I'll stop digging for now, then.

Cheers,
Jeff