Re: [PATCH V3 2/4] net-next: mediatek: fix gigabit and flow control advertisement

[David Miller]

From: John Crispin <john@xxxxxxxxxxx>
Date: Tue, 10 May 2016 07:08:39 +0200

> @@ -236,7 +247,8 @@ static int mtk_phy_connect(struct mtk_mac *mac)
>  	mac->phy_dev->autoneg = AUTONEG_ENABLE;
>  	mac->phy_dev->speed = 0;
>  	mac->phy_dev->duplex = 0;
> -	mac->phy_dev->supported &= PHY_BASIC_FEATURES;
> +	mac->phy_dev->supported &= PHY_GBIT_FEATURES | SUPPORTED_Pause |
> +				   ~SUPPORTED_Asym_Pause;

All this does is clear SUPPORTED_Asym_Pause.  Putting the other values
there, is therefore, superfluous.

I think you need to rethink through what you expect this expression to
accomplish.

Thanks.