Re: [PART1 V5 07/13] KVM: x86: Detect and Initialize AVIC support

From: Borislav Petkov
Date: Tue May 10 2016 - 12:24:33 EST


On Tue, May 10, 2016 at 04:43:05PM +0200, Paolo Bonzini wrote:
> That was actually our suggestion. Despite the long names, the lines do
> not come out too long because the masks are only used for writing
> fields, not very much for reading them (e.g. in complex "if" conditions).

Sure but how can one even read that?

AVIC_PHYSICAL_ID_ENTRY_HOST_PHYSICAL_ID_MASK

AVIC's physical ID entry's host's physical ID's mask?

That sucks in any language :-)

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.