Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation

From: Jaegeuk Kim
Date: Tue May 10 2016 - 22:32:39 EST


On Wed, May 11, 2016 at 10:22:05AM +0800, Chao Yu wrote:
> On 2016/5/11 5:41, Jaegeuk Kim wrote:
> > +
> > + f2fs_wait_on_page_writeback(dn->node_page, NODE, true);
> > +
> > + for (; count > 0; dn->ofs_in_node++) {
> > + block_t blkaddr =
> > + datablock_addr(dn->node_page, dn->ofs_in_node);
> > + if (blkaddr == NULL_ADDR) {
> > + dn->data_blkaddr = NEW_ADDR;
> > + __set_data_blkaddr(dn);
> > + count--;
> > + }
> > + }
>
> Should let ofs_in_node increase to offset where blkaddr = NULL_ADDR in
> ENOSPC case or increase to end_offset in normal case, right?

hehe, I could get some errors on this patch. :)
Finally, I've made a patch which passes xfstests and fsstress.
Could you find the latest ones?

http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/log/?h=dev-test

>
> Thanks,