RE: [PATCH V7 00/11] Support for generic ACPI based PCI host controller
From: Gabriele Paoloni
Date: Wed May 11 2016 - 06:42:42 EST
Hi Tomasz
> -----Original Message-----
> From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Tomasz Nowicki
> Sent: 10 May 2016 16:20
> To: helgaas@xxxxxxxxxx; arnd@xxxxxxxx; will.deacon@xxxxxxx;
> catalin.marinas@xxxxxxx; rafael@xxxxxxxxxx; hanjun.guo@xxxxxxxxxx;
> Lorenzo.Pieralisi@xxxxxxx; okaya@xxxxxxxxxxxxxx; jchandra@xxxxxxxxxxxx
> Cc: robert.richter@xxxxxxxxxxxxxxxxxx; mw@xxxxxxxxxxxx;
> Liviu.Dudau@xxxxxxx; ddaney@xxxxxxxxxxxxxxxxxx; Wangyijing;
> Suravee.Suthikulpanit@xxxxxxx; msalter@xxxxxxxxxx; linux-
> pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> acpi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linaro-
> acpi@xxxxxxxxxxxxxxxx; jcm@xxxxxxxxxx; andrea.gallo@xxxxxxxxxx;
> dhdang@xxxxxxx; jeremy.linton@xxxxxxx; liudongdong (C);
> cov@xxxxxxxxxxxxxx; Tomasz Nowicki
> Subject: [PATCH V7 00/11] Support for generic ACPI based PCI host
> controller
>
> From the functionality point of view this series may be split into the
> following logic parts:
> 1. New ECAM API and update for users of the pci-host-common API
> 2. Necessary fixes as the preparation for using driver on ARM64.
> 3. Use new MCFG interface and implement generic ACPI based PCI host
> controller driver.
> 4. Enable above driver on ARM64
>
> Patches has been built on top of 4.6-rc7 and can be found here:
> git@xxxxxxxxxx:semihalf-nowicki-tomasz/linux.git (pci-acpi-v7)
>
> This has been tested on Cavium ThunderX server. Any help in reviewing
> and
> testing is very appreciated.
>
> v6 -> v7
> - drop quirks handling
Maybe I missed something in the v6 discussion thread; when was it
decided to drop quirk handling?
I think it is important to have this in place to accommodate different
vendors. If the intention is to keep this patchset "clean" maybe
we can add it as a separate patch on top later on...
What’s your view?
Thanks
Gab
> - changes for ACPI companion and domain number assignment approach
> - implement arch pcibios_{add|remove}_bus and call
> acpi_pci_{add|remove}_bus from there
> - cleanups around nomenclature
> - use resources oriented API for ECAM
> - fix for based address calculation before mapping ECAM region
> - remove useless lock for MCFG lookup
> - move MCFG stuff to separated file pci_mcfg.c
> - drop MCFG entries caching
> - rebase against 4.6-rc7
>
> v5 -> v6
> - drop idea of x86 MMCONFIG code refactoring
> - integrate JC's patches which introduce new ECAM API:
> https://lkml.org/lkml/2016/4/11/907
> git: https://github.com/jchandra-brcm/linux/ (arm64-acpi-pci-v3)
> - integrate Sinan's fix for releasing IO resources, see patch [06/13]
> - added ACPI support for ThunderX ECAM and PEM drivers
> - rebase against 4.6-rc2
>
> v4 -> v5
> - drop MCFG refactoring group patches 1-6 from series v4 and integrate
> Jayachandran's patch
> https://patchwork.ozlabs.org/patch/575525/
> - rewrite PCI legacy IRQs allocation
> - squash two patches 11 and 12 from series v4, fixed bisection issue
> - changelog improvements
> - rebase against 4.5-rc3
>
> v3 -> v4
> - drop Jiang's fix
> http://lkml.iu.edu/hypermail/linux/kernel/1601.1/04318.html
> - add Lorenzo's fix patch 19/24
> - ACPI PCI bus domain number assigning cleanup
> - change resource management, we now claim and reassign resources
> - improvements for applying quirks
> - drop Matthew's http://www.spinics.net/lists/linux-pci/msg45950.html
> dependency
> - rebase against 4.5-rc1
>
> v2 -> v3
> - fix legacy IRQ assigning and IO ports registration
> - remove reference to arch specific companion device for ia64
> - move ACPI PCI host controller driver to pci_root.c
> - drop generic domain assignment for x86 and ia64 as I am not
> able to run all necessary test variants
> - drop patch which cleaned legacy IRQ assignment since it belongs to
> Mathew's series:
> https://patchwork.ozlabs.org/patch/557504/
> - extend MCFG quirk code
> - rebase against 4.4
>
> v1 -> v2
> - move non-arch specific piece of code to dirver/acpi/ directory
> - fix IO resource handling
> - introduce PCI config accessors quirks matching
> - moved ACPI_COMPANION_SET to generic code
>
> v1 - https://lkml.org/lkml/2015/10/27/504
> v2 - https://lkml.org/lkml/2015/12/16/246
> v3 - http://lkml.iu.edu/hypermail/linux/kernel/1601.1/04308.html
> v4 - https://lkml.org/lkml/2016/2/4/646
> v5 - https://lkml.org/lkml/2016/2/16/426
> v6 - https://lkml.org/lkml/2016/4/15/594
>
> Jayachandran C (2):
> PCI: Provide common functions for ECAM mapping
> PCI: generic, thunder: update to use generic ECAM API
>
> Tomasz Nowicki (9):
> pci, of: Move the PCI I/O space management to PCI core code.
> pci: Add new function to unmap IO resources.
> acpi, pci: Support IO resources when parsing PCI host bridge
> resources.
> pci, acpi: Provide a way to assign bus domain number.
> pci, acpi: Handle ACPI companion assignment.
> pci, acpi: Support for ACPI based generic PCI host controller
> arm64, pci, acpi: ACPI support for legacy IRQs parsing and
> consolidation with DT code.
> arm64, pci, acpi: Provide ACPI-specific prerequisites for PCI bus
> enumeration.
> arm64, pci, acpi: Start using ACPI based PCI host controller driver
> for ARM64.
>
> arch/arm64/Kconfig | 1 +
> arch/arm64/kernel/pci.c | 34 +++-----
> drivers/acpi/Kconfig | 8 ++
> drivers/acpi/Makefile | 1 +
> drivers/acpi/pci_mcfg.c | 97 ++++++++++++++++++++++
> drivers/acpi/pci_root.c | 33 ++++++++
> drivers/acpi/pci_root_generic.c | 149
> +++++++++++++++++++++++++++++++++
> drivers/of/address.c | 116 +-------------------------
> drivers/pci/Kconfig | 3 +
> drivers/pci/Makefile | 2 +
> drivers/pci/ecam.c | 161
> ++++++++++++++++++++++++++++++++++++
> drivers/pci/ecam.h | 72 ++++++++++++++++
> drivers/pci/host/Kconfig | 1 +
> drivers/pci/host/pci-host-common.c | 114 +++++++++++--------------
> drivers/pci/host/pci-host-common.h | 47 -----------
> drivers/pci/host/pci-host-generic.c | 52 +++---------
> drivers/pci/host/pci-thunder-ecam.c | 39 ++-------
> drivers/pci/host/pci-thunder-pem.c | 92 ++++++++++-----------
> drivers/pci/pci.c | 150
> ++++++++++++++++++++++++++++++++-
> drivers/pci/probe.c | 2 +
> include/linux/of_address.h | 9 --
> include/linux/pci-acpi.h | 14 ++++
> include/linux/pci.h | 11 ++-
> 23 files changed, 823 insertions(+), 385 deletions(-)
> create mode 100644 drivers/acpi/pci_mcfg.c
> create mode 100644 drivers/acpi/pci_root_generic.c
> create mode 100644 drivers/pci/ecam.c
> create mode 100644 drivers/pci/ecam.h
> delete mode 100644 drivers/pci/host/pci-host-common.h
>
> --
> 1.9.1