Re: [PATCH] x86: use compat version for preadv2 and pwritev2

From: Christoph Hellwig
Date: Thu May 12 2016 - 03:31:39 EST


On Wed, May 11, 2016 at 12:14:11PM +0200, Thomas Gleixner wrote:
> On Wed, 11 May 2016, Dmitry V. Levin wrote:
> > Similar to preadv and pwritev, preadv2 and pwritev2 need compat entries
> > in the 32-bit syscall table.
>
> So this is 2016 and we added a syscalls which require compat support. What's
> wrong here?

Nothing. It's and extension of readv/writev and uses struct iovec,
which is different for compat vs native. We have efficient infrastructure
to deal with that in the kernel, while in userspace people would have
to copy around all the iovecs for every I/O, which would be a nightmare.