Re: [PATCH] Input - ntrig_spi: add new driver for the Surface 3

From: Dmitry Torokhov
Date: Thu May 12 2016 - 15:56:47 EST


On Thu, May 12, 2016 at 09:51:22PM +0200, Benjamin Tissoires wrote:
> On May 12 2016 or thereabouts, Dmitry Torokhov wrote:
> > On Thu, May 12, 2016 at 05:07:54PM +0200, Benjamin Tissoires wrote:
> > > +static int __maybe_unused ntrig_spi_suspend(struct device *dev)
> > > +{
> > > + struct spi_device *spi = to_spi_device(dev);
> > > + struct ntrig *data = spi_get_drvdata(spi);
> > > +
> > > + ntrig_spi_free_irq(data);
> >
> > Why?
>
> To disable the IRQ and be sure we won't wake up the device...
> It might just work without though.

Or you can do disable_irq(). Do you want it to be wakeup source by
chance? Then you need to wire it up some more.

Thanks.

--
Dmitry