Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings

From: Alan Cooper
Date: Thu May 12 2016 - 19:02:45 EST


On Thu, May 12, 2016 at 3:24 AM, chunfeng yun <chunfeng.yun@xxxxxxxxxxxx> wrote:
>> > + - mediatek,enable-manual-drd : supports manual dual-role switch by sysfs
>> > + interface; only used when receptacle is TYPE-A and also wants to support
>> > + dual-role mode.
>>
>> sysfs is a Linux detail that doesn't apply to the binding. Does the
>> property mean "the IP block supports or doesn't support switching" or
>> "I want to enable switching feature". Only the former belongs in DT.
>>
> It is the former case, and has little relation with sysfs interface.
> I will modify it later, sorry for my unclear description.

Could the property name be just "enable-manual-drd" instead of
"mediatek,enable-manual-drd"? I expect to have to add this
functionality to our USB driver in the near future.