Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi

From: Andy Shevchenko
Date: Fri May 13 2016 - 09:11:15 EST


On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote:
> From: Kejian Yan <yankejian@xxxxxxxxxx>
>
> Dsaf needs to get configuration parameter by ACPI, so this patch add
> support of ACPI.
>

Looks like at some point better to split driver to core part, and PCI
and ACPI/DT/platform code.

Too many changes where IS_ENABLED() involved shows as I can imagine bad
architecture / split of the driver.

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy