Re: [PATCH] iommu/rockchip: fix zap cache during device attach

From: Heiko Stuebner
Date: Sat May 14 2016 - 16:20:06 EST


Am Dienstag, 10. Mai 2016, 16:50:46 schrieb John Keeping:
> rk_iommu_command() takes a struct rk_iommu and iterates over the slave
> MMUs, so this is doubly wrong in that we're passing in the wrong pointer
> and talking to MMUs that we shouldn't be.
>
> Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi
> slaves") Signed-off-by: John Keeping <john@xxxxxxxxxxxx>

on a rk3288-veyron
Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>

I was wondering for a short time why this didn't spew warnings until I
realized that the iommu->bases[i] is of course a void* .


Heiko