Re: [RFC][WARNING] warning in uncore_pci_probe

[Thomas Gleixner]

On Tue, 17 May 2016, Jiri Olsa wrote:
> 
> [    2.766466] WARNING: CPU: 0 PID: 1 at arch/x86/events/intel/uncore.c:894 uncore_pci_probe+0x2a8/0x2b0
> 
> I'm booting with nr_cpus=1, which impact physical_to_logical_pkg
> setup.. the map will not be initialized because the rest of cpus
> is never initialized and set in cpu_present_mask
>
> it seems to me we should remove the warning, because it's valid to
> have only single cpu allowed

Single package that is. The package map for cpu 0 is correct, i.e. package 0,
but that code tries to init the PCI/uncore for the other packages.

So, yes. The WARN_ON() is wrong there. We should just return and be done with
it.

Thanks,

	tglx