Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

[Greg KH]

On Wed, May 18, 2016 at 12:03:58PM -0400, Jes Sorensen wrote:
> Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> > On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote:
> >> > Ok, but still no need to put it under arch/ anything, it should go in
> >> > drivers/ like all other drivers and busses are, no matter what the arch
> >> > it happens to run on is.
> >> 
> >> I don't think thats obvious. arch/x86/kvm is an example of this, Sparc
> >> and PPC also have their stuff under arch/.
> >
> > For some things, yes, but let's not make the same mistakes as others :)
> >
> > Look at drivers/hv/ for an example of a very x86-only bus and driver
> > subsystem living in drivers/  Please don't burry driver stuff in arch/
> > the ARM developers are trying to fix their mistakes of the past and move
> > all of their cruft out of arch/ for that reason.
> 
> Works for me.
> 
> So should they put it in drivers/visorbus or drivers/bus/visorbus?

drivers/visorbus please.  drivers/bus/ is an "odd" thing :(

> What about drivers/virt? Would you suggest hv and xen gets moved in
> there?

Ah, yeah, that would be great, never noticed it before, despite being
there since 2011...

thanks,

greg k-h