Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

From: Andrew Lunn
Date: Thu May 19 2016 - 08:15:51 EST

> To be honest I don't know how the PHY LEDs could be set by LED triggers.
> Wouldn't that require to create triggers for each value which can be written
> to LEDxH and LEDxL? In my case the hardware requires some specific setting due
> to LED connections.

Supporting all possibilities is not possible. However you could
picking out a subset which other PHYs could also implement. Think
about the typical patterns you see if you have two LEDs, which seems
to be the most common setup.

We would have generic PHY trigger code, and a driver specific part
which configures the PHY to that configuration, if the trigger is