Re: [PATCH 2/2] char/nvram: fix style issues

From: kbuild test robot
Date: Fri May 20 2016 - 07:14:18 EST


Hi,

[auto build test ERROR on char-misc/char-misc-next]
[cannot apply to v4.6 next-20160519]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/LABBE-Corentin/char-nvram-set-array-of-const-as-const/20151105-174316
config: i386-defconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

Note: the linux-review/LABBE-Corentin/char-nvram-set-array-of-const-as-const/20151105-174316 HEAD 458f91db725087e7bb91bfad834b304e72ec9a9b builds fine.
It only hurts bisectibility.

All errors (new ones prefixed by >>):

drivers/char/nvram.c: In function 'nvram_init':
>> drivers/char/nvram.c:457:3: error: implicit declaration of function 'pri_err' [-Werror=implicit-function-declaration]
pri_err("nvram: can't create /proc/driver/nvram\n");
^~~~~~~
cc1: some warnings being treated as errors

vim +/pri_err +457 drivers/char/nvram.c

451 if (ret) {
452 pr_err("nvram: can't misc_register on minor=%d\n", NVRAM_MINOR);
453 goto out;
454 }
455 ret = nvram_add_proc_fs();
456 if (ret) {
> 457 pri_err("nvram: can't create /proc/driver/nvram\n");
458 goto outmisc;
459 }
460 ret = 0;

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data