Re: [PATCH] remove unused blkdev_dax_capable() function

From: Kani, Toshimitsu
Date: Fri May 20 2016 - 11:48:33 EST


FYI, fs/block_dev.c has multiple updates since then including the code in
question. I just built tot -next m64 kernel with the attached config file,
and confirmed no compile error on the file.
-Toshi

On Fri, 2016-05-20 at 19:32 +0800, kbuild test robot wrote:
> Hi,
>
> [auto build test ERROR on next-20160517]
> [cannot apply to v4.6-rc7 v4.6-rc6 v4.6-rc5 v4.6]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:ÂÂÂÂhttps://github.com/0day-ci/linux/commits/Arnd-Bergmann/remove-unu
> sed-blkdev_dax_capable-function/20160518-155729
> config: m68k-allyesconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 4.9.0
> reproduce:
> ÂÂÂÂÂÂÂÂwget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.g
> it/plain/sbin/make.cross -O ~/bin/make.cross
> ÂÂÂÂÂÂÂÂchmod +x ~/bin/make.cross
> ÂÂÂÂÂÂÂÂ# save the attached .config to linux build tree
> ÂÂÂÂÂÂÂÂmake.cross ARCH=m68kÂ
>
> All errors (new ones prefixed by >>):
>
> ÂÂÂfs/block_dev.c: In function '__blkdev_get':
> >
> > >
> > > fs/block_dev.c:1242:5: error: implicit declaration of function
> > > 'blkdev_dax_capable' [-Werror=implicit-function-declaration]
> ÂÂÂÂÂÂÂÂif (!blkdev_dax_capable(bdev))
> ÂÂÂÂÂÂÂÂ^
> ÂÂÂcc1: some warnings being treated as errors
>
> vim +/blkdev_dax_capable +1242 fs/block_dev.c
>
> d3374825 NeilBrownÂÂÂÂ2009-01-09ÂÂ1236ÂÂ
> goto restart;
> d3374825 NeilBrownÂÂÂÂ2009-01-09ÂÂ1237ÂÂ }
> 1196f8b8 Tejun HeoÂÂÂÂ2011-04-21ÂÂ1238ÂÂ }
> 7e69723f Tejun HeoÂÂÂÂ2011-05-23ÂÂ1239ÂÂ
> 5a023cdb Dan Williams 2015-11-30ÂÂ1240ÂÂ if (!ret)
> {
> 7e69723f Tejun HeoÂÂÂÂ2011-05-23ÂÂ1241ÂÂ b
> d_set_size(bdev,(loff_t)get_capacity(disk)<<9);
> 5a023cdb Dan Williams 2015-11-30 @1242ÂÂ i
> f (!blkdev_dax_capable(bdev))
> 5a023cdb Dan Williams 2015-11-30ÂÂ1243ÂÂ
> bdev->bd_inode->i_flags &= ~S_DAX;
> 5a023cdb Dan Williams 2015-11-30ÂÂ1244ÂÂ }
> 7e69723f Tejun HeoÂÂÂÂ2011-05-23ÂÂ1245ÂÂ
>
> :::::: The code at line 1242 was first introduced by commit
> :::::: 5a023cdba50c5f5f2bc351783b3131699deb3937 block: enable dax for raw
> block devices
>
> :::::: TO: Dan Williams <dan.j.williams@xxxxxxxxx>
> :::::: CC: Dan Williams <dan.j.williams@xxxxxxxxx>
>
> ---
> 0-DAY kernel test infrastructureÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂOpen Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-allÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂIntel
> Corporation