Re: [PATCH v5 2/5] mmc: core: add mmc-hs400-enhanced-strobe support

From: Doug Anderson
Date: Mon May 23 2016 - 16:53:56 EST


Shawn,

On Sun, May 22, 2016 at 9:13 PM, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
> This patch introduce mmc-hs400-enhanced-strobe for platforms
> which want to enable enhanced strobe function from DT if the
> mmc host controller claims to support enhanced strobe.
>
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
>
> ---
>
> Changes in v5:
> - avoid to call hs400_enhanced+_strobe in mmc_set_initial_state
> if no setting MMC_CAP2_HS400_ES.
> - add Adrian's ack for patch[5/5]
>
> Changes in v4:
> - check avail_type with EXT_CSD_CARD_TYPE_HS400 instead of
> card_type
> - check if host support 8-bit when selecting hs400es
> - some minor fix suggested by Douglas and add his review tag
>
> Changes in v3:
> - remove helper function and shorten cap2 to MMC_CAP2_HS400_ES
> - rename callback to hs400_enhanced_strobe and make it return void
> - add enhanced_strobe in mmc_ios and pass it to hs400_enhanced_strobe
> - disable host's enhanced strobe in mmc_set_initial_state
> - remove bus checking after switching hs400es
> - add new function for hs400es timing selection
> - fix wrong judgement of mmc_card_hs400es
>
> Changes in v2:
> - switch to HS400ES from Highspeed mode directly
>
> drivers/mmc/core/host.c | 2 ++
> include/linux/mmc/host.h | 1 +
> 2 files changed, 3 insertions(+)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>