Re: [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl

From: Greg Kroah-Hartman
Date: Mon May 23 2016 - 17:28:17 EST


On Mon, May 23, 2016 at 01:07:53PM +0000, Winkler, Tomas wrote:
> >
> > From: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> >
> > wr_ctrl waiters are none interruptible, so should be waken up with call to
> > wake_up and not to wake_up_interruptible.
> >
> > This fixes commit:
> > 7ff4bdd ("mei: fix waiting for wr_ctrl for corner cases.")
> >
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
>
> Hi Greg,
> I see this fix didn't make it to rc1, so currently the driver is somehow broken.
> Can you please make an effort and include the fix in next rc?

Ugh, didn't realize it was totally broken, the patch didn't really say
that, sorry. I'll queue it up once 4.7-rc1 is out.

thanks,

greg k-h