Re: [PATCH V12 2/2] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024

From: Linus Walleij
Date: Tue May 24 2016 - 07:21:15 EST


On Fri, May 13, 2016 at 7:19 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:

> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO pins
> which also act as the special function in alternate mode. Also
> there is configuration like push-pull, open drain, FPS timing
> etc for these pins.
>
> Add pin control driver to configure these parameters through
> pin control APIs.
>
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Patch applied for the next kernel cycle.

> + switch (param) {
> + case PIN_CONFIG_DRIVE_OPEN_DRAIN:
> + if (mpci->pin_info[pin].drv_type == MAX77620_PIN_OD_DRV)
> + arg = 1;
> + break;

Hmmmm OK is this one of those cases we discussed where
you need to be able to tell the pin config back-end to do the
open draining (etc) from the GPIO driver?

Yours,
Linus Walleij