Re: [PATCH 1/7] mm: Cleanup - Reorganize the shrink_page_list code into smaller functions

From: Tim Chen
Date: Fri May 27 2016 - 12:40:43 EST


On Tue, 2016-05-03 at 14:01 -0700, Tim Chen wrote:
> This patch prepares the code for being able to batch the anonymous
> pages
> to be swapped out.ÂÂIt reorganizes shrink_page_list function with
> 2 new functions: handle_pgout and pg_finish.
>
> The paging operation in shrink_page_list is consolidated into
> handle_pgout function.
>
> After we have scanned a page shrink_page_list and completed any
> paging,
> the final disposition and clean up of the page is conslidated into
> pg_finish.ÂÂThe designated disposition of the page from page scanning
> in shrink_page_list is marked with one of the designation in
> pg_result.
>
> This is a clean up patch and there is no change in functionality or
> logic of the code.

Hi Michal,

We've talked about doing the clean up of shrink_page_list code
before attempting to do batching on the swap out path as those
set of patches I've previously posted are quit intrusive. ÂWonder
if you have a chance to look at this patch and has any comments?

Thanks.

Tim