Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking
From: Thomas Gleixner
Date: Wed Jun 01 2016 - 02:43:13 EST
On Tue, 31 May 2016, David Kershner wrote:
> + /*
> + * If we're not paused, really enable interrupts.
> + * Regardless of whether we are paused, set a flag indicating
> + * interrupts should be enabled so when we resume, interrupts
> + * will really be enabled.
> + */
> + down_write(&devdata->lock_visor_dev);
Why is this a rw_semaphore? It's only ever taken with down_write() and it's
always the same context. Should be a mutex, right?
While at it, please convert the notifier_lock to a mutex as well.