Re: [PATCH v3 5/5] usb: dwc3: rockchip: add devicetree bindings documentation

From: William Wu
Date: Wed Jun 01 2016 - 05:03:36 EST

Dear Sergei,

On 05/27/2016 07:54 PM, Sergei Shtylyov wrote:

On 5/27/2016 2:31 PM, William Wu wrote:

This patch documents the device tree documentation required for

Documents the documentation? :-)
Ah, my commit log seems a little weird. I'll corrcet it next patch. Thanks.:-)

Rockchip USB3.0 core wrapper consist of USB3.0 IP from Synopsys.

I'll correct it next patch. Thanks again.

It could operate in device mode (SS, HS, FS) and host
mode (SS, HS, FS, LS).

Signed-off-by: William Wu <william.wu@xxxxxxxxxxxxxx>
Changes in v3:
- add dwc3 address (Felipe)

Changes in v2:
- add rockchip,dwc3.txt to Documentation/devicetree/bindings/ (Felipe, Brian)

.../devicetree/bindings/usb/rockchip,dwc3.txt | 45 ++++++++++++++++++++++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/rockchip,dwc3.txt

diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
new file mode 100644
index 0000000..0bb52fe
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
@@ -0,0 +1,45 @@
+Rockchip SuperSpeed DWC3 USB SoC controller
+Required properties:
+- compatible: should contain "rockchip,dwc3"
+- clocks: A list of phandle + clock-specifier pairs for the
+ clocks listed in clock-names
+- clock-names: Should contain the following:
+ "clk_usb3otg0_ref" Controller reference clk
+ "clk_usb3otg0_suspend"Controller suspend clk, can use 24 MHz or 32 KHz
+ "aclk_usb3" Master/Core clock, have to be >= 62.5 MHz for SS operation
+Optional clocks:
+ "aclk_usb3otg0" Aclk for specific usb controller clock.
+ "aclk_usb3_rksoc_axi_perf" USB AXI perf clock. Not present on all platforms.
+ "aclk_usb3_grf" USB grf clock. Not present on all platforms.
+Required child node:
+A child node must exist to represent the core DWC3 IP block. The name of
+the node is not important. The content of the node is defined in dwc3.txt.
+Phy documentation is provided in the following places:

Actually, our phy driver and document is not ready yet. I just add it here earlier. Add after we upload the phy driver and document, we can fix the PHY here.
Is that OK?


MBR, Sergei