Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c

From: Ian Abbott
Date: Wed Jun 01 2016 - 05:29:13 EST

On 31/05/16 18:07, Joe Perches wrote:
On Tue, 2016-05-31 at 11:29 +0100, Ian Abbott wrote:
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:

This is a patch to the s626.c file that fixes up a type issues like
i.e Prefer kernel type 'u8' over 'uint8_t'
Prefer kernel type 'u16' over 'uint16_t'
Prefer kernel type 'u32' over 'uint32_t'
Prefer kernel type 's16' over 'int16_t'
Prefer kernel type 's32' over 'int32_t'
found by the tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya
changes since v1: Rework
drivers/staging/comedi/drivers/s626.c | 212 +++++++++++++++++-----------------
1 file changed, 106 insertions(+), 106 deletions(-)

Thanks. It would have been nice if the tool detected
_all_ the instances of these types. As a result of this patch, s626.c
contains a mixture of the different integer type styles. I guess we can
fix that up later though.

Seems trivial enough to do.

There was a possible issue with converting int_t types that
were used as uapi function arguments.

checkpatch currently warns only about variable declarations and
not function declarations. It doesn't convert casts either.

Oh right, I wasn't sure what the pattern was. It does warn about int_t types in _some_function declarations, but on closer inspection, it only seems to do so when there is a line break before the parameter declaration. For example:

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#519: FILE: drivers/staging/comedi/drivers/s626.c:519:
+ uint16_t chan, int16_t dacdata)

-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: )=-