Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L
From: Dmitry Torokhov
Date: Wed Jun 01 2016 - 14:17:26 EST
On Wed, Jun 01, 2016 at 05:39:44PM +0100, Nick Dyer wrote:
> This is a series of patches to add diagnostic data support to the Atmel
> maXTouch driver. It's a rewrite of the previous implementation which output via
> debugfs: it now uses a V4L2 device in a similar way to the sur40 driver.
> There are significant performance advantages to putting this code into the
> driver. The algorithm for retrieving the data has been fairly consistent
> across a range of chips, with the exception of the mXT1386 series (see patch).
> We have a utility which can read the data and display it in a useful format:
> These patches are also available from
> Changes in v3:
> - Address V4L2 review comments from Hans Verkuil
> - Run v4l-compliance and fix all issues - needs minor patch here:
> Changes in v2:
> - Split pixfmt changes into separate commit and add DocBook
> - Introduce VFL_TYPE_TOUCH_SENSOR and /dev/v4l-touch
> - Remove "single node" support for now, it may be better to treat it as metadata later
> - Explicitly set VFL_DIR_RX
> - Fix Kconfig
I do not have any objections other than some nits form the input side;
majority of the review should come from V4L2 side here...