Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410

From: Javier Martinez Canillas
Date: Wed Jun 01 2016 - 16:53:06 EST

Hello Krzysztof,

On 06/01/2016 04:06 PM, Krzysztof Kozlowski wrote:
> On Wed, Jun 1, 2016 at 9:57 PM, Kevin Hilman <khilman@xxxxxxxxxx> wrote:
>> Hi Krzysztof,
>> On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>> Just like other Exynos5 family SoCs, this one has four UARTs. Configure
>>> clocks for UART3 and enable it.
>>> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>>> Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>> This patch landed in linux-next[1] and found a boot
>> regression on the exynos5410-odroidxu[2], where it looks like it's
>> faulting in clk_prepare(). Bisecting pointed to this patch. I added
>> "status = disabled" back into the DTS on top of next-20160601[3] and
>> verified my odroid-XU to be booting fine again.
> Hi,
> Thanks for report. Indeed the patch brings up to the light an issue in
> serial driver. Fixed here:
> I left the commit in my tree as it is correct (strictly speaking).
> Sorry for any trouble it makes.

Kevin pointed me to this issue over IRC and I was able to reproduce it in
my Peach Pi by removing the UART3 clocks from the Exynos5420 clock driver.

Your patch indeed fixes the issue, I'll add a Reviewed-by on that thread.

> Best regards,
> Krzysztof

Best regards,
Javier Martinez Canillas
Open Source Group
Samsung Research America