Re: [PATCH v2 4/8] zram: use crypto api to check alg availability
From: Minchan Kim
Date: Wed Jun 01 2016 - 22:40:10 EST
On Wed, Jun 01, 2016 at 04:48:45PM +0900, Sergey Senozhatsky wrote:
> On (06/01/16 15:47), Minchan Kim wrote:
> > > so both BUILTIN and BUILT-AS-A-MODULE cases are handled at compile
> > > time now and we can avoid crypto_has_comp() checks for most of the
> > > comp_algorithm calls, except for the case when someone requests an
> > > out-of-tree module.
> > Hmm, isn't it problem, either?
> > That module was built but not installed. In that case, setting the
> > algorithm will be failed. IOW, we are lying to user.
> have you ever seen this? really, why should we even bother?
> if there is no requested algorithm we will fallback to LZO.
Yeb, it seems I am too paranoid. Let's not take care about the case.
We can simple return -EINVAL and fallback lzo.