Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up
From: Vincent Guittot
Date: Thu Jun 02 2016 - 02:57:08 EST
On 1 June 2016 at 21:35, Yuyang Du <yuyang.du@xxxxxxxxx> wrote:
> On Wed, Jun 01, 2016 at 11:24:45AM +0200, Vincent Guittot wrote:
>> > So with the patch, we will have a little bit semantic change, SD_BALANCE_WAKE
>> > implies SD_WAKE_AFFINE if allowed, and will favor "fast path" if possible. I don't
>> > think we should do anything otherwise.
>> Why should we not do anything else ?
>> The current default configuration is to only use the wake_affine path.
>> With your changes, the default configuration will try to use wake
>> affine and will fall back to long load balance sequence if wake affine
>> doesn't find a sched_domain
>> That's a major changes in the behavior
> Well, I won't argue that this hasn't changed, but I'd argue that this change
> isn't a bad change: (a) it restores the flags to their meanings and makes them
Have you any proof that this change is not a bad thing ? Moreover have
you got proof that it's a good thing ? Changing the meaning and the
behavior of flags, just because you find it elegant, doesn't seem to
be enough for me.
So if you just want to rename the flags please keep current behavior unchange
> more "elegant", (b) we definitely need further work to improve
> select_task_rq_fair(), there has already been a comment marked XXX, right? :)