Re: [PATCH] i2c: designware: Enable ioctl I2C_TIMEOUT

From: Uwe Kleine-König
Date: Thu Jun 02 2016 - 04:33:42 EST

On Thu, Jun 02, 2016 at 03:57:30PM +0800, Weifeng Voon wrote:
> This allows applications to set the transfer timeout in 10ms increments via
> ioctl I2C_TIMEOUT.

10ms is only correct with HZ=100. With higher values of HZ you get a
finer resolution. I'd write:

Respect the transfer timeout set via the I2C_TIMEOUT ioctl.

and not mention the resolution at all. After all your patch doesn't
"enable" that ioctl, just makes use of the value set by it.

Best regards

Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | |