Re: [PATCH 5/5] intel_idle: Add S0ix validation
From: Peter Zijlstra
Date: Thu Jun 02 2016 - 05:25:18 EST
On Wed, Jun 01, 2016 at 09:33:29PM -0700, dbasehore@xxxxxxxxxxxx wrote:
> + * Default chosen to have <= 1% power increase while allowing fast detection of
> + * SLP S0 entry errors. Waking up 10 times a second shows ~30% increase in
> + * system power on Skylake Y. Waking up once every 10 seconds is
> + * indistinguishable from not waking up at all (as ~0.3% power increase would
> + * be). Any reasonable power increases above this will not be visible to the
> + * user.
> + */
> +#define DEFAULT_SLP_S0_SECONDS 10
So I don't think anybody waits for 10 seconds to see if suspend worked.
After 10 seconds its in the bag and I'm out the door.
Why can't you fire a single timer after 0.5 seconds to see if you hit
C10 and leave it at that? What's the point any further wakeup, if you
know you hit C10, you're good continue on.